Initial Commit for Advanced Batching #11544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangan12
commented
Sep 29, 2020
xirzec
reviewed
Sep 29, 2020
sdk/search/search-documents/src/searchIndexingBufferedSender.ts
Outdated
Show resolved
Hide resolved
sarangan12
commented
Oct 1, 2020
| import { createSpan } from "./tracing"; | ||
| import { CanonicalCode } from "@opentelemetry/api"; | ||
|
|
||
| const DEFAULT_BATCH_SIZE: number = 1000; |
There was a problem hiding this comment.
For this release, we are not allowing the user to modify these values. For next release, we will decide on what is the actual logic to be used. (Batch size vs Threshold Size, Simple Retry Count vs Retry Policy )
sarangan12
commented
Oct 1, 2020
| * @param options Options to modify batch size, auto flush and flush window. | ||
| * | ||
| */ | ||
| constructor(client: SearchClient<T>, options: SearchIndexingBufferedSenderOptions = {}) { |
There was a problem hiding this comment.
For this release, I am keeping the constructor just like Python
xirzec
reviewed
Oct 1, 2020
...search-documents/samples/typescript/src/bufferedSender/uploadDocuments/autoFlushSizeBased.ts
Show resolved
Hide resolved
...earch-documents/samples/typescript/src/bufferedSender/uploadDocuments/autoFlushTimerBased.ts
Outdated
Show resolved
Hide resolved
sdk/search/search-documents/src/searchIndexingBufferedSender.ts
Outdated
Show resolved
Hide resolved
sdk/search/search-documents/src/searchIndexingBufferedSender.ts
Outdated
Show resolved
Hide resolved
sdk/search/search-documents/src/searchIndexingBufferedSender.ts
Outdated
Show resolved
Hide resolved
xirzec
approved these changes
Oct 1, 2020
...earch-documents/samples/typescript/src/bufferedSender/uploadDocuments/autoFlushTimerBased.ts
Outdated
Show resolved
Hide resolved
This was referenced Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xirzec
This PR is to add fancy batch supporting for the search-documents SDK.