Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Rename options/responses interfaces of the flattened API - storage-queue #5590

Closed
HarshaNalluru opened this issue Oct 16, 2019 · 4 comments
Closed

[Storage] Rename options/responses interfaces of the flattened API - storage-queue #5590

HarshaNalluru opened this issue Oct 16, 2019 · 4 comments
Assignees
@ramya-rao-a
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@HarshaNalluru
Copy link
Member

#5579 (comment)
@HarshaNalluru HarshaNalluru added the blocking-release Blocks release label Oct 16, 2019
@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Oct 16, 2019
@HarshaNalluru
Copy link
Member Author

#5102

@HarshaNalluru HarshaNalluru mentioned this issue Oct 16, 2019
Closed
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Oct 17, 2019 •
edited
Loading

I was able to find the below changes to be made. @HarshaNalluru, @jeremymeng Can you confirm?

  • MessagesClearOptions -> QueueClearMessagesOptions
  • MessagesClearResponse -> QueueClearMessagesResponse
  • MessagesEnqueueOptions -> QueueSendMessageOptions
  • MessagesEnqueueResponse -> QueueSendMessageResponse
  • MessagesDequeueOptions -> QueueReceiveMessageOptions
  • MessagesDequeueResponse -> QueueReceiveMessageResponse
  • MessagesPeekOptions -> QueuePeekMessagesOptions
  • MessagesPeekResponse -> QueuePeekMessagesResponse
  • MessageIdDeleteOptions -> QueueDeleteMessageOptions
  • MessageIdDeleteResponse-> QueueDeleteMessageResponse
  • MessageIdUpdateOptions -> QueueUpdateMessageOptions
  • MessageIdUpdateResponse-> QueueUpdateMessageResponse

@ramya-rao-a ramya-rao-a self-assigned this Oct 17, 2019
@ramya-rao-a ramya-rao-a mentioned this issue Oct 17, 2019
Merged
@ramya-rao-a
Copy link
Contributor

I have created a PR #5617 that handles the above changes except the ones that live in the generated files.

  • MessageIdUpdateResponse-> QueueUpdateMessageResponse
  • MessageIdDeleteResponse-> QueueDeleteMessageResponse
  • MessagesClearResponse -> QueueClearMessagesResponse

Side note:
The types that are defined in the convenience layer extend the auto generated types whose names we might want to change as well. For example, QueueReceiveMessageOptions extends Models.MessagesDequeueOptionalParams. Ideally it should be Models.QueueReceiveMessageOptionalParams

@ramya-rao-a
Copy link
Contributor

Updated PR #5617 to deal with the 3 response types above by creating type aliases. See c7537cf

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HarshaNalluru @ramya-rao-a