[KeyVault] - Types of property signRequest are incompatible (outdated ms-rest-js 1.0 reference)

[ak99372]

• Package Name: @azure/keyvault
• Package Version: 0.1.0
• Operating system:
• nodejs
  • version: 10.15.1
• typescript
  • version: 3.4

Describe the bug
KeyVault package is referencing outdated ms-auzre-js package version 1.0 (ServiceClientCredentials) and fails to compile when used with ms-rest-nodeauth reference with following error:

Argument of type 'import("/node_modules/@azure/ms-rest-js/es/lib/credentials/serviceClientCredentials").ServiceClientCredentials' is not assignable to parameter of type 'import("/node_modules/@azure/keyvault/node_modules/@azure/ms-rest-js/es/lib/credentials/serviceClientCredentials").ServiceClientCredentials'.
  Types of property 'signRequest' are incompatible.
    Type '(webResource: import("/node_modules/@azure/ms-rest-js/es/lib/webResource").WebResource) => Promise<import("/node_modules/@azure/ms-rest-js/es/lib/webResource").WebResource>' is not assignable to type '(webResource: import("/node_modules/@azure/keyvault/node_modules/@azure/ms-rest-js/es/lib/webResource").WebResource) => Promise<...>'.
      Types of parameters 'webResource' and 'webResource' are incompatible.
        Type 'import("/node_modules/@azure/keyvault/node_modules/@azure/ms-rest-js/es/lib/webResource").WebResource' is not assignable to type 'import("/node_modules/@azure/ms-rest-js/es/lib/webResource").WebResource'.
          Types of property 'headers' are incompatible.
            Type 'import("/node_modules/@azure/keyvault/node_modules/@azure/ms-rest-js/es/lib/httpHeaders").HttpHeaders' is not assignable to type 'import("/node_modules/@azure/ms-rest-js/es/lib/httpHeaders").HttpHeaders'.
              Types have separate declarations of a private property '_headersMap'.

To Reproduce
Steps to reproduce the behavior:

import { ServiceClientCredentials } from '@azure/ms-rest-js';
import * as azureAuth from '@azure/ms-rest-nodeauth';
import * as KeyVault from '@azure/keyvault';

const credentials = await azureAuth.loginWithVmMSI();
const keyVaultClient = new KeyVault.KeyVaultClient(credentials);

Expected behavior
Package to be compatible with latest @azure/ms-rest-js and @azure/ms-rest-nodeauth

[daviwil]

Hi @ak99372, it is intentional that @azure/keyvault does not support ms-rest-js 2.0; many of our libraries don't currently support it because we have been moving over to a new stack that is based on @azure/core-http.

@azure/keyvault is now deprecated in favor of @azure/keyvault-keys and @azure/keyvault-secrets. Could you try one of those libraries to verify that it works for you in the scenarios that you care about?

Thanks!

[ghost]

Thanks for working with Microsoft on GitHub! Tell us how you feel about your experience using the reactions on this comment.