Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-amqp] Standardize unit of time to milliseconds #4277

Closed
ramya-rao-a opened this issue Jul 11, 2019 · 1 comment
Closed

[core-amqp] Standardize unit of time to milliseconds #4277

ramya-rao-a opened this issue Jul 11, 2019 · 1 comment
Assignees
@ramya0820
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone
Sprint 156

Comments

@ramya-rao-a
Copy link
Contributor

There are quite a few places in core-amqp where we deal with seconds.
Now that we have finalized on using milliseconds as the unit of time for the user facing inputs, it helps if the same is standardized across Event Hubs and core-amqp so that we avoid the multiplication/division by 1000 in multiple places
@ramya-rao-a ramya-rao-a added this to the Sprint 156 milestone Jul 11, 2019
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jul 11, 2019
@ramya0820 ramya0820 self-assigned this Jul 23, 2019
This was referenced Jul 23, 2019
Merged
Merged
@ramya-rao-a
Copy link
Contributor Author

Completed with #4401

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya0820 ramya0820

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
Sprint 156
Development

No branches or pull requests
2 participants
@ramya-rao-a @ramya0820