Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] Allow users to configure retry options in streaming receiver #2833

Closed
ramya-rao-a opened this issue May 12, 2019 · 2 comments
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented May 12, 2019

Allow users to configure retry options in the streaming receiver as described in #2661 (comment)

Using retries for the creation of receiver link is covered in #2835

@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Event Hubs labels May 12, 2019
@ramya-rao-a ramya-rao-a added this to the Sprint 153 milestone May 12, 2019
@ShivangiReja ShivangiReja self-assigned this May 20, 2019
@ramya-rao-a
Copy link
Contributor Author

Thoughts after offline discussions:

The only place where retries make most sense for streaming receiver is to ensure that for retryable errors, we bring up the receiver link behind the scenes and resume receiving events without bothering the user.

For such a case, we currently use a much higher "retryAttempts" to ensure that we cover the case of intermittent network loss. The problem with using a client level default for such scenario is that such defaults are usually low and won't serve the purpose outlined in the previous line.

Proposal is to have a separate kind of a retry options that are specifically used for re-establishing failed AMQP links or connections.

@ramya-rao-a
Copy link
Contributor Author

As per the API proposal in #2718 (comment), we will now have a createReceiver() method on the Event Hub Client that returns a receiver. It is on this method that we will be allowing retry options rather than individual operations.

Therefore, closing this issue in favor of #3184

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

No branches or pull requests

2 participants