Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable web view customization for interactive authN #25277

Closed
scottaddie opened this issue Mar 16, 2023 · 2 comments · Fixed by #27444
Closed

Enable web view customization for interactive authN #25277

scottaddie opened this issue Mar 16, 2023 · 2 comments · Fixed by #27444
Assignees
@KarishmaGhiya
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
2023-10

Comments

@scottaddie
Copy link
Member

scottaddie commented Mar 16, 2023 •
edited by christothes
Loading

Context:
Azure PowerShell relies on the Azure Identity library to use MSAL. Currently, we're required to customize the web view displayed after authentication, which requires the Azure Identity library to open new properties that are already supported by MSAL.

The primary scenario to enable here is to expose an option to control whether the embedded or system browser will be invoked.
@scottaddie scottaddie added Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. labels Mar 16, 2023
@scottaddie scottaddie added this to the Backlog milestone Mar 16, 2023
@joshfree joshfree modified the milestones: Backlog, 2023-05 Apr 3, 2023
@joshfree joshfree modified the milestones: 2023-05, 2023-06 Apr 30, 2023
@joshfree joshfree modified the milestones: 2023-06, 2023-07 Jun 19, 2023
@joshfree joshfree modified the milestones: 2023-07, 2023-08 Jul 17, 2023
@joshfree joshfree moved this from Blocked to Planned in Azure Identity SDK Improvements Jul 17, 2023
@christothes
Copy link
Member

see .NET PR for an example: Azure/azure-sdk-for-net#34095

@KarishmaGhiya KarishmaGhiya self-assigned this Jul 28, 2023
@KarishmaGhiya KarishmaGhiya mentioned this issue Aug 1, 2023
Closed
@KarishmaGhiya KarishmaGhiya moved this from Planned to Blocked in Azure Identity SDK Improvements Aug 1, 2023
@KarishmaGhiya KarishmaGhiya moved this from Blocked to Planned in Azure Identity SDK Improvements Aug 1, 2023
@joshfree joshfree moved this from Planned to Blocked in Azure Identity SDK Improvements Aug 8, 2023
@joshfree joshfree modified the milestones: 2023-08, 2023-10 Aug 8, 2023
@joshfree
Copy link
Member

joshfree commented Aug 8, 2023

The JS impl is currently blocked on an MSAL regression, so moving this out 2-months. @KarishmaGhiya / @mpodwysocki please link to the corresponding tracking MSAL github issue, and let's work with them to get us unblocked for an upcoming monthly release.

@joshfree joshfree moved this from Blocked to Not Started in Azure Identity SDK Improvements Sep 29, 2023
@KarishmaGhiya KarishmaGhiya mentioned this issue Oct 18, 2023
Merged
2 tasks
@joshfree joshfree moved this from Not Started to In Progress in Azure Identity SDK Improvements Oct 23, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure Identity SDK Improvements Oct 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KarishmaGhiya KarishmaGhiya

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
2023-10
Development

Successfully merging a pull request may close this issue.

[identity] Enable browser customization for web view KarishmaGhiya/azure-sdk-for-js
4 participants
@christothes @joshfree @KarishmaGhiya @scottaddie