Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] Consumer Group setup #1975

Closed
zajacmp3 opened this issue Apr 3, 2019 · 5 comments
Closed

[Event Hubs] Consumer Group setup #1975

zajacmp3 opened this issue Apr 3, 2019 · 5 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Milestone

Comments

@zajacmp3
Copy link

zajacmp3 commented Apr 3, 2019

Is your feature request related to a problem? Please describe.
Evaluation of javascript SDK revealed that there is no way to set consumer group for connection string.

Describe the solution you'd like
Add this feature

Describe alternatives you've considered
Routing messages to other event hub

Additional context
I found out that this was possible in the past. https://medium.com/@xaviergeerinck/sending-and-receiving-events-with-azure-event-hub-f92af9ad7fa0

@kurtzeborn kurtzeborn added the Client This issue points to a problem in the data-plane of the library. label Apr 3, 2019
@triage-new-issues triage-new-issues bot removed the triage label Apr 3, 2019
@triage-new-issues triage-new-issues bot removed the triage label Apr 3, 2019
@kurtzeborn
Copy link
Member

kurtzeborn commented Apr 3, 2019

Thank you for opening this issue! We are routing it to the appropriate team for follow up.

CC: @ramya-rao-a

@ramya-rao-a
Copy link
Contributor

Thanks for reporting @zajacmp3

The link provided was using a library that I was not able to find on npmjs.com

The current library (@azure/event-hubs) does support the use of consumer group. But instead of passing it as a direct argument, you will have to pass it in the options argument

For both the above receive operations, the last parameter is of the type ReceiveOptions where you can pass the consumer group.

@ShivangiReja, please update our samples to pass the default consumer group in the options parameter

@ramya-rao-a ramya-rao-a added the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Apr 3, 2019
@zajacmp3
Copy link
Author

zajacmp3 commented Apr 4, 2019

Thanks, I missed that option while reviewing the interface... Must be blind :) Can be closed but obviously docs could be updated.

@ramya-rao-a
Copy link
Contributor

No worries :) Happens to the best of us

We will use this issue to track not only updating of the samples, but to improve the README to include some code snippets as well

@amarzavery amarzavery added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 3, 2019
@ramya-rao-a ramya-rao-a added this to the Sprint 152 milestone May 7, 2019
@ShivangiReja ShivangiReja self-assigned this May 9, 2019
@ramya-rao-a
Copy link
Contributor

With a23fafb, the samples now show how to pass the consumer group to the receive operation

The readme has been updated with the note on ReceiveOptions as well.

Thanks for reporting @zajacmp3

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

5 participants