Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide APIs to be left in preview ahead of Ni GA #18127

Closed
4 tasks done
schaabs opened this issue Oct 11, 2021 · 5 comments · Fixed by #18129
Closed
4 tasks done

Hide APIs to be left in preview ahead of Ni GA #18127

schaabs opened this issue Oct 11, 2021 · 5 comments · Fixed by #18129
Assignees
@sadasant
Labels
Azure.Identity blocking-release Blocks release
Milestone
[2021] November

Comments

@schaabs
Copy link
Member

schaabs commented Oct 11, 2021 •
edited by sadasant
Loading

There are APIs we intend to keep in preview and they need to be hidden from the public API ahead of this GA. These include:

  • RegionalAuthority enumeration
  • Region property from ClientSecretCredentialOptions and ClientCertificateCredentialOptions
  • AzureApplicationCredential
  • AzureAppliationCredentialOptions
@schaabs schaabs added this to the [2021] November milestone Oct 11, 2021
@sadasant
Copy link
Contributor

sadasant commented Oct 11, 2021 •
edited
Loading

Regional Authority was hidden here: #18026 also the region property.

@sadasant
Copy link
Contributor

AzureApplicationCredential was fixed here: #18110

@sadasant
Copy link
Contributor

I’m closing this.

@schaabs
Copy link
Member Author

schaabs commented Oct 11, 2021

Looks like you didn't hide AzureApplicationCredential just renamed it following the review. It also should be made non-public so it's not released in this GA.

@schaabs schaabs reopened this Oct 11, 2021
@sadasant
Copy link
Contributor

@schaabs ohh correct! thank you

@sadasant sadasant mentioned this issue Oct 11, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Azure.Identity blocking-release Blocks release
Projects
None yet
Milestone
[2021] November
Development

Successfully merging a pull request may close this issue.

[Identity] Removed AzureApplicationCredential from our public API sadasant/azure-sdk-for-js
2 participants
@sadasant @schaabs