Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prebuild from package.json files #17125

Closed
xirzec opened this issue Aug 25, 2021 · 4 comments
Closed

Remove prebuild from package.json files #17125

xirzec opened this issue Aug 25, 2021 · 4 comments
Assignees
Labels
EngSys This issue is impacting the engineering system.

Comments

@xirzec
Copy link
Member

xirzec commented Aug 25, 2021

Rush doesn't actually run/support prebuild when doing rush build / rush rebuild:

microsoft/rushstack#830

Which means that if we make certain kinds of changes in the tree, we'll get build errors after pulling the latest main. The fix for this is to update our build tasks to do cleaning rather than relying on prebuild to call it for us.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 25, 2021
@ramya-rao-a ramya-rao-a added the EngSys This issue is impacting the engineering system. label Aug 26, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 26, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] September milestone Aug 26, 2021
@ramya-rao-a
Copy link
Contributor

@sadasant Assigning this to you as you are already covering this in #17123

@ramya-rao-a
Copy link
Contributor

@sadasant A lot of the packages updated in #17123 are autogenerated. We should skip making changes to them manually. Instead, the changes should be done in the code generator and the package should be updated whenever the package owner decides to make ship the next update.

Can you please log an issue in the https://github.com/Azure/autorest.typescript repo so that these changes dont get reverted the next time these packages are updated?

@sadasant
Copy link
Contributor

For sure! on it!

@sadasant
Copy link
Contributor

@ramya-rao-a I could be wrong but I think we can close this now :)

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

3 participants