Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventGrid] No system event mappings for ChatThreadParticipantAdded and ChatThreadParticipantRemoved #14345

Closed
6 tasks
vikrampraveen opened this issue Mar 17, 2021 · 2 comments
Closed
6 tasks

[EventGrid] No system event mappings for ChatThreadParticipantAdded and ChatThreadParticipantRemoved #14345

vikrampraveen opened this issue Mar 17, 2021 · 2 comments
Assignees
@ellismg
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Event Grid
Milestone
[2021] April

Comments

@vikrampraveen
Copy link

vikrampraveen commented Mar 17, 2021 •
edited
Loading

  • Package Name:
  • Package Version:
  • Operating system:
  • nodejs
    • version:
  • browser
    • name/version:
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
AcsChatParticipantAddedToThreadEvent/AcsChatParticipantRemovedFromThreadEvent system event mapping is broken resulting in Microsoft.Communication.ChatThreadParticipantAdded/Microsoft.Communication.ChatThreadParticipantRemoved events not being usable in the SDK

To Reproduce
Steps to reproduce the behavior:

  1. Attempt to parse Microsoft.Communication.ChatThreadParticipantAdded/Microsoft.Communication.ChatThreadParticipantRemoved events using the SDK

Expected behavior
Successfully able retrieve event payload Microsoft.Communication.ChatThreadParticipantAdded/Microsoft.Communication.ChatThreadParticipantRemoved

Actual behavior (include Exception or Stack Trace)
What is the actual behavior?
SDK rejects the payload due to missing system event mapping

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 17, 2021
@ramya-rao-a
Copy link
Contributor

Hey @vikrampraveen

Can you share which package are you using here for Communication Chat?
This repo is for JS SDKs for Azure services.
Looking at the details you shared, it looks like you are using the .Net SDK in which case https://github.com/Azure/azure-sdk-for-net is the right place to log the issue

@ellismg
Copy link
Member

ellismg commented Mar 22, 2021

This is related to EventGrid and how we handle system events. Assigning to myself.

@ellismg ellismg self-assigned this Mar 22, 2021
@ellismg ellismg added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Mar 22, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 22, 2021
@ellismg ellismg added Event Grid needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 22, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 22, 2021
@ellismg ellismg added this to the [2021] April milestone Mar 22, 2021
@ellismg ellismg changed the title AcsChatParticipantAddedToThreadEvent/AcsChatParticipantRemovedFromThreadEvent system event mapping is broken resulting in Microsoft.Communication.ChatThreadParticipantAdded/Microsoft.Communication.ChatThreadParticipantRemoved events not being usable in the SDK [EventGrid] No system event mappings for ChatThreadParticipantAdded and ChatThreadParticipantRemoved Mar 22, 2021
ellismg added a commit to ellismg/azure-sdk-for-js that referenced this issue Mar 22, 2021
@ellismg
[EventGrid] Fix ACS Event Names
e2c47af 
The Azure Communication Services team noticed that some of their event
shapes were wrong and have [updated the
swagger](Azure/azure-rest-api-specs#13485) to
address this.

This commit pulls these changes into our SDK.

Fixes Azure#14345
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ellismg ellismg

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Event Grid
Projects
None yet
Milestone
[2021] April
Development

No branches or pull requests
3 participants
@ellismg @vikrampraveen @ramya-rao-a