Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault] Remove dist-browser #12224

Closed
sophiajt opened this issue Nov 2, 2020 · 0 comments · Fixed by #12655
Closed

[KeyVault] Remove dist-browser #12224

sophiajt opened this issue Nov 2, 2020 · 0 comments · Fixed by #12655
Assignees
@sadasant
Labels
KeyVault
Milestone
MQ-2020

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Nov 2, 2020 •
edited
Loading

  • Package Name: keyvault packages
  • Package Version: current

As per the current recommendations: we shouldn't ship dist-browser directories as part of our npm packages. Looks like keyvault is still shipping these directories.

This is a reminder to remove this directory so that developers won't depend on it. Instead, we should encourage them to bundle their own set of libraries.

Current guidance is to link devs to: https://github.com/Azure/azure-sdk-for-js/blob/master/documentation/Bundling.md
@sadasant sadasant added this to the MQ-2020 milestone Nov 2, 2020
@sadasant sadasant mentioned this issue Nov 21, 2020
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Dec 24, 2020
CodeGen from PR 12224 in Azure/azure-rest-api-specs
0c389d7 
[Hub Generated] Review request for Microsoft.IoTCentral to add version stable/2018-09-01 (Azure#12224)

* update to name

* update
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
KeyVault
Projects
None yet
Milestone
MQ-2020
Development

Successfully merging a pull request may close this issue.

[Key Vault] Excluding dist-browser from the artifacts sadasant/azure-sdk-for-js
2 participants
@sadasant @sophiajt