Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Key Vault Keys Readme Issue #11493

Closed
zzhxiaofeng opened this issue Sep 25, 2020 · 1 comment · Fixed by #11601
Closed

Azure Key Vault Keys Readme Issue #11493

zzhxiaofeng opened this issue Sep 25, 2020 · 1 comment · Fixed by #11601
Assignees
@sadasant
Labels
Client This issue points to a problem in the data-plane of the library. Docs KeyVault needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass
Milestone
[2020] October

Comments

@zzhxiaofeng
Copy link
Contributor

zzhxiaofeng commented Sep 25, 2020 •
edited
Loading

Section link
Screenshot 2020-09-25 174102
Reason:
Use wrong function.

Suggestion:
Update signData to sign.

@jongio for notification.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 25, 2020
@tzhanl tzhanl added Client This issue points to a problem in the data-plane of the library. Docs KeyVault needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass labels Sep 25, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 25, 2020
@ramya-rao-a
Copy link
Contributor

Thanks for reporting @zzhxiaofeng

@sadasant, Do you agree with the recommendation above? If not, then please provide your recommendation after which

  • add the labels bug, help wanted and good first issue
  • remove the label needs-team-triage
  • assign the issue to the backlog milestone

@sadasant sadasant added this to the [2020] October milestone Sep 28, 2020
sadasant added a commit that referenced this issue Oct 2, 2020
@sadasant
[Key Vault Keys] Fixed wrong method in a readme sample
f82f378 
The readme sample for the `sign` method of the CryptographyClient was using `signData`.

Fixes #11493

@zzhxiaofeng thank you!

Reviews appreciated.
@sadasant sadasant mentioned this issue Oct 2, 2020
Merged
sadasant added a commit that referenced this issue Oct 2, 2020
@sadasant
[Key Vault Keys] Fixed wrong method in a readme sample (#11601)
c7f70e6 
The readme sample for the `sign` method of the CryptographyClient was using `signData`.

Fixes #11493

@zzhxiaofeng thank you!

Reviews appreciated.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Client This issue points to a problem in the data-plane of the library. Docs KeyVault needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass
Projects
None yet
Milestone
[2020] October
Development

Successfully merging a pull request may close this issue.

[Key Vault Keys] Fixed wrong method in a readme sample Azure/azure-sdk-for-js
4 participants
@sadasant @ramya-rao-a @zzhxiaofeng @tzhanl