Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sample code in readme files for the Cognitive Services auto generated packages to use JavaScript #10196

Closed
ramya-rao-a opened this issue Jul 22, 2020 · 1 comment
Closed

Update sample code in readme files for the Cognitive Services auto generated packages to use JavaScript #10196

ramya-rao-a opened this issue Jul 22, 2020 · 1 comment
Assignees
@sarangan12
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive Services Docs feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
[2020] September

Comments

@ramya-rao-a
Copy link
Contributor

Currently, the code sample generated in the readme file of a generated package is in TypeScript.

To help with copy -> paste -> run code workflow, it is much easier to have the same in JavaScript than TypeScript.

There is a higher probability of TypeScript users knowing JavaScript than the other way around.

This issue is to update the readme files in all the generated packages under sdk/cognitiveservices.

Changes would be

  • Update the import statements
  • Remove all "types"
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Cognitive Services Docs labels Jul 22, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] September milestone Jul 22, 2020
@ramya-rao-a ramya-rao-a added the feature-request This issue requires a new behavior in the product in order be resolved. label Jul 22, 2020
This was referenced Jul 27, 2020
Closed
Merged
@sarangan12
Copy link
Contributor

All samples in the readme have been updated. All SDKs have been released except

  1. QnAMaker
    2.QnAMakerRuntime
  2. Text Analytics
  3. LUIS Authoring
  4. LUIS Runtime

Created Issue #10304 for QnAMaker & QnAMaker Runtime SDKs. Rest do not need release now

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarangan12 sarangan12

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive Services Docs feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
[2020] September
Development

No branches or pull requests
2 participants
@sarangan12 @ramya-rao-a