From 39a30e8a0338fc50a06c970a98bd4671d7992b25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Rodr=C3=ADguez?= Date: Tue, 30 Jul 2019 15:46:07 -0400 Subject: [PATCH] [KeyVault] dotenv fix (#4533) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With this change, we can have a `.env` file in `sdk/keyvault` (the parent folder, as well as with other of our projects using dotenv) with the following properties: ``` AZURE_CLIENT_ID=XXXXXXXX AZURE_CLIENT_SECRET=XXXXXXXX AZURE_TENANT_ID=XXXXXXXX KEYVAULT_NAME=XXXXXXXX TEST_MODE=["record" or "playback", without quotes] ``` And then run `rushx integration-test:node` to record (or playback) all the tests with the Node environment, and also `rushx integration-test:browser` to run the tests with the browser environment. Would this help with #4389 ? Please review 💙 --- sdk/keyvault/keyvault-keys/tests/utils/recorder.ts | 2 +- sdk/keyvault/keyvault-secrets/tests/utils/recorder.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/keyvault/keyvault-keys/tests/utils/recorder.ts b/sdk/keyvault/keyvault-keys/tests/utils/recorder.ts index f2f22b5d58e0..6a86badc44c1 100644 --- a/sdk/keyvault/keyvault-keys/tests/utils/recorder.ts +++ b/sdk/keyvault/keyvault-keys/tests/utils/recorder.ts @@ -7,7 +7,7 @@ import { retry as realRetry } from "./retry"; import { isNode as coreIsNode, delay as coreDelay } from "@azure/core-http"; import queryString from "query-string"; import * as dotenv from "dotenv"; -dotenv.config({ path: "../../.env" }); +dotenv.config({ path: "../.env" }); export function isBrowser(): boolean { return typeof window !== "undefined"; diff --git a/sdk/keyvault/keyvault-secrets/tests/utils/recorder.ts b/sdk/keyvault/keyvault-secrets/tests/utils/recorder.ts index f60217fc2a9c..087c0646ad38 100644 --- a/sdk/keyvault/keyvault-secrets/tests/utils/recorder.ts +++ b/sdk/keyvault/keyvault-secrets/tests/utils/recorder.ts @@ -8,7 +8,7 @@ import { retry as realRetry } from "./retry"; import { isNode as coreIsNode } from "@azure/core-http"; import queryString from "query-string"; import * as dotenv from "dotenv"; -dotenv.config({ path: "../../.env" }); +dotenv.config({ path: "../.env" }); export function isBrowser(): boolean { return typeof window !== "undefined";