[core-http] Remove the FetchHttpClient (#18863)

Removed the `FetchHttpClient`, which was used as the base abstract class for the `DefaultHttpClient`. It wasn’t exposed until this very recent PR: #18755
Azure · Dec 1, 2021 · 2200b2b · 2200b2b
1 parent 47eff03
commit 2200b2b
Show file tree

Hide file tree

Showing 8 changed files with 274 additions and 391 deletions.
diff --git a/sdk/core/core-http/package.json b/sdk/core/core-http/package.json
@@ -53,7 +53,6 @@
     "./dist-esm/src/util/base64.js": "./dist-esm/src/util/base64.browser.js",
     "./dist-esm/src/util/xml.js": "./dist-esm/src/util/xml.browser.js",
     "./dist-esm/src/defaultHttpClient.js": "./dist-esm/src/defaultHttpClient.browser.js",
-    "./dist-esm/src/fetchHttpClient.js": "./dist-esm/src/fetchHttpClient.browser.js",
     "./dist-esm/src/util/inspect.js": "./dist-esm/src/util/inspect.browser.js",
     "./dist-esm/src/util/url.js": "./dist-esm/src/util/url.browser.js"
   },

diff --git a/sdk/core/core-http/review/core-http.api.md b/sdk/core/core-http/review/core-http.api.md
@@ -174,10 +174,11 @@ export function createSpanFunction(args: SpanConfig): <T extends OperationOption
 };
 
 // @public
-export class DefaultHttpClient extends FetchHttpClient {
+export class DefaultHttpClient implements HttpClient {
     fetch(input: CommonRequestInfo, init?: CommonRequestInit): Promise<CommonResponse>;
     prepareRequest(httpRequest: WebResourceLike): Promise<Partial<RequestInit>>;
     processRequest(operationResponse: HttpOperationResponse): Promise<void>;
+    sendRequest(httpRequest: WebResourceLike): Promise<HttpOperationResponse>;
 }
 
 // @public
@@ -245,14 +246,6 @@ export class ExpiringAccessTokenCache implements AccessTokenCache {
 // @public
 export function exponentialRetryPolicy(retryCount?: number, retryInterval?: number, maxRetryInterval?: number): RequestPolicyFactory;
 
-// @public
-export abstract class FetchHttpClient implements HttpClient {
-    abstract fetch(input: CommonRequestInfo, init?: CommonRequestInit): Promise<CommonResponse>;
-    abstract prepareRequest(httpRequest: WebResourceLike): Promise<Partial<RequestInit>>;
-    abstract processRequest(operationResponse: HttpOperationResponse): Promise<void>;
-    sendRequest(httpRequest: WebResourceLike): Promise<HttpOperationResponse>;
-}
-
 // @public
 export function flattenResponse(_response: HttpOperationResponse, responseSpec: OperationResponse | undefined): RestResponse;
 

diff --git a/sdk/core/core-http/src/coreHttp.ts b/sdk/core/core-http/src/coreHttp.ts
@@ -14,12 +14,7 @@ export {
   RequestOptionsBase,
   TransferProgressEvent
 } from "./webResource";
-export {
-  CommonResponse,
-  CommonRequestInit,
-  CommonRequestInfo,
-  FetchHttpClient
-} from "./fetchHttpClient";
+export { CommonResponse, CommonRequestInit, CommonRequestInfo } from "./nodeFetchHttpClient";
 export { DefaultHttpClient } from "./defaultHttpClient";
 export { HttpClient } from "./httpClient";
 export { HttpHeader, HttpHeaders, HttpHeadersLike, RawHttpHeaders } from "./httpHeaders";

diff --git a/sdk/core/core-http/src/fetchHttpClient.browser.ts b/sdk/core/core-http/src/fetchHttpClient.browser.ts