diff --git a/sdk/search/search-documents/src/searchIndexClient.ts b/sdk/search/search-documents/src/searchIndexClient.ts index d6030e2765fe..295166bac812 100644 --- a/sdk/search/search-documents/src/searchIndexClient.ts +++ b/sdk/search/search-documents/src/searchIndexClient.ts @@ -40,13 +40,19 @@ import { import * as utils from "./serviceUtils"; import { createSpan } from "./tracing"; import { odataMetadataPolicy } from "./odataMetadataPolicy"; -import { SearchClient, SearchClientOptions } from "./searchClient"; +import { SearchClient } from "./searchClient"; /** * Client options used to configure Cognitive Search API requests. */ export type SearchIndexClientOptions = PipelineOptions; +/** + * Alias of Search Index Client Options parameter to satisfy linting constraints + */ + +type getSearchClientOptions = SearchIndexClientOptions; + /** * Class to perform operations to manage * (create, update, list/delete) @@ -611,7 +617,7 @@ export class SearchIndexClient { * @param indexName Name of the index * @param options SearchClient Options */ - public getSearchClient(indexName: string, options?: SearchClientOptions): SearchClient { + public getSearchClient(indexName: string, options?: getSearchClientOptions): SearchClient { return new SearchClient(this.endpoint, indexName, this.credential, options || this.options); } } diff --git a/sdk/search/search-documents/src/searchIndexingBufferedSender.ts b/sdk/search/search-documents/src/searchIndexingBufferedSender.ts index f711de209ad0..b06b0e81216f 100644 --- a/sdk/search/search-documents/src/searchIndexingBufferedSender.ts +++ b/sdk/search/search-documents/src/searchIndexingBufferedSender.ts @@ -1,3 +1,6 @@ +// Copyright (c) Microsoft Corporation. +// Licensed under the MIT license. + import { IndexDocumentsAction, SearchIndexingBufferedSenderUploadDocumentsOptions, diff --git a/sdk/search/search-documents/src/serviceUtils.ts b/sdk/search/search-documents/src/serviceUtils.ts index e1a611fb5c01..2e82a4c8da67 100644 --- a/sdk/search/search-documents/src/serviceUtils.ts +++ b/sdk/search/search-documents/src/serviceUtils.ts @@ -283,7 +283,7 @@ export function convertSimilarityToPublic( return similarity; } - if (similarity.odatatype == "#Microsoft.Azure.Search.ClassicSimilarity") { + if (similarity.odatatype === "#Microsoft.Azure.Search.ClassicSimilarity") { return similarity as ClassicSimilarity; } else { return similarity as BM25Similarity; @@ -370,7 +370,9 @@ export function generatedIndexToPublicIndex(generatedIndex: GeneratedSearchIndex }; } -export function generatedSearchResultToPublicSearchResult(results: GeneratedSearchResult[]) { +export function generatedSearchResultToPublicSearchResult( + results: GeneratedSearchResult[] +): SearchResult[] { const returnValues: SearchResult[] = results.map>((result) => { const { _score, _highlights, ...restProps } = result; const doc: { [key: string]: any } = { diff --git a/sdk/search/search-documents/test/node/searchClient.spec.ts b/sdk/search/search-documents/test/node/searchClient.spec.ts index b51648f21ba1..1649ad7c9b16 100644 --- a/sdk/search/search-documents/test/node/searchClient.spec.ts +++ b/sdk/search/search-documents/test/node/searchClient.spec.ts @@ -62,7 +62,7 @@ describe("SearchClient", function() { it("autocomplete returns zero results for invalid query", async function() { const autoCompleteResult: AutocompleteResult = await searchClient.autocomplete("garbxyz", "sg"); - assert.isTrue(autoCompleteResult.results.length == 0); + assert.isTrue(autoCompleteResult.results.length === 0); }); it("search returns the correct search result", async function() { diff --git a/sdk/search/search-documents/test/node/searchIndexClient.spec.ts b/sdk/search/search-documents/test/node/searchIndexClient.spec.ts index 5422fa28f418..97752c3ab032 100644 --- a/sdk/search/search-documents/test/node/searchIndexClient.spec.ts +++ b/sdk/search/search-documents/test/node/searchIndexClient.spec.ts @@ -99,8 +99,6 @@ describe("SearchIndexClient", function() { ]; assert.include(synonyms, synonymMap.synonyms[0]); assert.include(synonyms, synonymMap.synonyms[1]); - } catch (ex) { - throw ex; } finally { await indexClient.deleteSynonymMap(synonymMap); } @@ -207,8 +205,6 @@ describe("SearchIndexClient", function() { index = await indexClient.getIndex(indexName); assert.equal(index.name, indexName); assert.equal(index.fields.length, 5); - } catch (ex) { - throw ex; } finally { await indexClient.deleteIndex(index); } diff --git a/sdk/search/search-documents/test/node/searchIndexerClient.spec.ts b/sdk/search/search-documents/test/node/searchIndexerClient.spec.ts index 717ef38956e6..95f6c8b42a71 100644 --- a/sdk/search/search-documents/test/node/searchIndexerClient.spec.ts +++ b/sdk/search/search-documents/test/node/searchIndexerClient.spec.ts @@ -109,8 +109,6 @@ describe("SearchIndexerClient", function() { assert.equal(indexer.dataSourceName, "my-data-source-1"); assert.equal(indexer.targetIndexName, TEST_INDEX_NAME); assert.isFalse(indexer.isDisabled); - } catch (ex) { - throw ex; } finally { await indexerClient.deleteIndexer(indexer); } @@ -178,8 +176,6 @@ describe("SearchIndexerClient", function() { assert.equal(dataSourceConnection.name, "my-data-source-3"); assert.equal(dataSourceConnection.type, "cosmosdb"); assert.equal(dataSourceConnection.container.name, "hotels"); - } catch (ex) { - throw ex; } finally { await indexerClient.deleteDataSourceConnection(dataSourceConnection); } @@ -267,8 +263,6 @@ describe("SearchIndexerClient", function() { assert.equal(skillSet.skills.length, 1); assert.equal(skillSet.skills[0].inputs.length, 2); assert.equal(skillSet.skills[0].outputs.length, 3); - } catch (ex) { - throw ex; } finally { await indexerClient.deleteSkillset(skillSet); }