New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX study feedback update part 1 #7897

Merged

samvaity merged 5 commits into Azure:master from samvaity:rename-ta

Feb 4, 2020

Member

samvaity commented Feb 1, 2020 •

edited

Loading

This PR covers the frollowing workitems from the UX study feedback

Rename erroneousDocumentCount to invalidDocumentCount
Rename NamedEntity -> CategorizedEntity
Rename type and subtype properties on NamedEntity to category and subCategory.
Create new model PiiEntitiesResult and return it for getPiiEntities on RecognizePiiEntitiesResult.
Delete s from all detectLanguage method overloads.

samvaity requested a review from mssfang as a code owner

February 1, 2020 00:52

samvaity self-assigned this

samvaity requested review from kristapratico, maririos, willmtemple, xirzec, joshfree and JonathanGiles

February 1, 2020 00:53

kristapratico reviewed

View reviewed changes

sdk/textanalytics/azure-ai-textanalytics/README.md Outdated Show resolved Hide resolved

JonathanGiles reviewed

View reviewed changes

Member

JonathanGiles left a comment

From a quick scan this looks good to me.

maririos reviewed

View reviewed changes

...e-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsClientTestBase.java Show resolved Hide resolved

maririos reviewed

View reviewed changes

...zure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/TextAnalyticsAsyncClient.java Outdated Show resolved Hide resolved

maririos reviewed

View reviewed changes

...ics/azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/TextAnalyticsClient.java Outdated Show resolved Hide resolved

maririos reviewed

View reviewed changes

...e-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsClientTestBase.java Outdated Show resolved Hide resolved

maririos reviewed

View reviewed changes

...e-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsClientTestBase.java Outdated Show resolved Hide resolved

samvaity requested review from danieljurek, JimSuplizio, mitchdenny, srnagar and weshaggard as code owners

February 3, 2020 19:39

samvaity requested review from maririos and kristapratico and removed request for mitchdenny, danieljurek, weshaggard and srnagar

February 3, 2020 19:40

kristapratico reviewed

View reviewed changes

...re-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/RecognizeEntityAsyncClient.java Show resolved Hide resolved

kristapratico reviewed

View reviewed changes

...ai-textanalytics/src/main/java/com/azure/ai/textanalytics/RecognizePiiEntityAsyncClient.java Show resolved Hide resolved

kristapratico approved these changes

View reviewed changes

Member

kristapratico left a comment

LGTM, just a few questions ^

maririos approved these changes

View reviewed changes

JimSuplizio approved these changes

View reviewed changes

Member

JimSuplizio left a comment

The version update looks fine.

samvaity force-pushed the rename-ta branch from bfccf0c to 1a3ff83 Compare

February 4, 2020 20:22

samvaity added 4 commits

February 4, 2020 13:38


          UX study feedback update

ca3cea5


          update readme

9901b0d


          Named -> Categorized

55a74d1


          rename to entities

6c8178b

samvaity force-pushed the rename-ta branch from 1a3ff83 to 5e259be Compare

February 4, 2020 21:40


          readme conflicts

f838800

samvaity force-pushed the rename-ta branch from 5e259be to f838800 Compare

February 4, 2020 21:40

samvaity merged commit c8ed1b0 into Azure:master

mssfang mentioned this pull request

[UX Study] Address UserStudy feedbacks #7594

Closed

14 tasks

samvaity deleted the rename-ta branch

September 17, 2020 20:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JonathanGiles JonathanGiles left review comments

annelo-msft annelo-msft left review comments

kristapratico kristapratico approved these changes

maririos maririos approved these changes

JimSuplizio JimSuplizio approved these changes

mssfang Awaiting requested review from mssfang

willmtemple Awaiting requested review from willmtemple

xirzec Awaiting requested review from xirzec

joshfree Awaiting requested review from joshfree

Labels

None yet