Nio file store2 #7857
Nio file store2 #7857
Conversation
| * {@inheritDoc} | ||
| */ | ||
| public class AzureStorageFileAttributeView implements FileAttributeView { | ||
|
|
There was a problem hiding this comment.
This type was created in this PR so that the AzureFileStore type can accurately say it is supported, but it will be given actual functionality in a later PR when setting blob/file attributes is added.
...storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureStorageFileAttributeView.java
Show resolved
Hide resolved
sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileStore.java
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileStore.java
Outdated
Show resolved
Hide resolved
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public long getTotalSpace() throws IOException { | ||
| return 0; | ||
| return Long.MAX_VALUE; |
There was a problem hiding this comment.
Would -1 or a public constant be a better value for this to have clear indication that this is a unique value and shouldn't be used to determine code paths or in validation.
There was a problem hiding this comment.
I imagine there might be scenarios where customers might try to compare the amount of space in a store with the (possibly predicted) amount of data they have. In that case, a getTotalSpace() > dataSize check would always fail. Just speculation, though. Thoughts?
sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileStore.java
Outdated
Show resolved
Hide resolved
|
/azp run java - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Implemented fileStoreAttributeView * file store tests * Added recordings * PR feedback * checkstyle
No description provided.