Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update spotbugs plugin config #7754

Merged
merged 1 commit into from
Jan 29, 2020
Merged

update spotbugs plugin config #7754

merged 1 commit into from
Jan 29, 2020

Conversation

g2vinay
Copy link
Member

@g2vinay g2vinay commented Jan 28, 2020 •
edited
Loading

Currently, spotbugs check are only running on src/main of all Track 2 SDKs.
Adding the disabled test inclusion flag to spotbugs config.
Will enable it, once Track 2 SDKs src/test and src/samples are spotbugs clean in our repo.

@g2vinay g2vinay marked this pull request as ready for review January 28, 2020 02:48
JonathanGiles
JonathanGiles approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generate the reports and send them to me - I will put them online and you can then share the issues identified with the team.

@g2vinay g2vinay merged commit b61d12a into master Jan 29, 2020
@weshaggard weshaggard deleted the spotbugs-tests-exclusion branch February 3, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanGiles JonathanGiles JonathanGiles approved these changes

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@srnagar srnagar Awaiting requested review from srnagar

@joshfree joshfree Awaiting requested review from joshfree

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g2vinay @JonathanGiles @alzimmermsft