Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed upsertItem API to use upsertItem instead of createItem() #7692

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Fixed upsertItem API to use upsertItem instead of createItem() #7692

merged 1 commit into from
Jan 24, 2020

Conversation

kushagraThapar
Copy link
Member

@kushagraThapar
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

moderakh
moderakh approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it.

we should have tests covering v3/v4 public surface area if we already don't (not in the scope of this PR though just something to consider in future)

@kushagraThapar
Copy link
Member Author

Thanks for fixing it.

we should have tests covering v3/v4 public surface area if we already don't (not in the scope of this PR though just something to consider in future)

Good point, we definitely should have it. I will create a github item for this at least for v4.

@kushagraThapar
Copy link
Member Author

Thanks for fixing it.
we should have tests covering v3/v4 public surface area if we already don't (not in the scope of this PR though just something to consider in future)

Good point, we definitely should have it. I will create a github item for this at least for v4.

We can track it here now: #7698

@kushagraThapar kushagraThapar merged commit 84baa3c into Azure:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbhaskar mbhaskar mbhaskar approved these changes

@moderakh moderakh moderakh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kushagraThapar @mbhaskar @moderakh