Removing buggy default Content-Type setting in OkHttpAsyncClient #7677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
approved these changes
Jan 23, 2020
JonathanGiles
approved these changes
Jan 23, 2020
alzimmermsft
pushed a commit
to alzimmermsft/azure-sdk-for-java
that referenced
this pull request
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OkHttpClient is incorrectly set a default content-type. The client-sdk that uses headers to compute auth signing value ignore the Content-Type when it is null but later OkHttpClient adds Content-Type that result in service to fail on evaluating the signing header.
Ref: #7234