Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Environment Proxy Configurations #7593

Merged

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Jan 21, 2020

Updated the Netty and OkHttp HttpClients to check the environment for proxy configuration if the ProxyOptions set in their builder is null. Additionally, added the ability to set the Configuration object that the builders will use when retrieving proxy information from the environment.

Environment proxy configurations will be loaded in the following order:

  1. Azure HTTPS
  2. Azure HTTP
  3. Java HTTPS
  4. Java HTTP

Azure proxy configurations are preferred over the Java proxy configurations as they relate more closely to the SDKs, additionally HTTPS is preferred over HTTP as it is more secure. Java proxies will require java.net.useSystemProxies to be true before that proxy configuration is applied.

@alzimmermsft alzimmermsft added the Azure.Core azure-core label Jan 21, 2020
@alzimmermsft alzimmermsft self-assigned this Jan 21, 2020
@alzimmermsft alzimmermsft marked this pull request as ready for review January 22, 2020 18:34
@joshfree joshfree added the Client This issue points to a problem in the data-plane of the library. label Jan 23, 2020
@joshfree joshfree added this to the [2020] February milestone Jan 23, 2020
@alzimmermsft
Copy link
Member Author

@srnagar I replied to your comments if you want to do another quick pass.

@alzimmermsft alzimmermsft merged commit 5a19707 into Azure:master Jan 29, 2020
@alzimmermsft alzimmermsft deleted the AzCore_SupportJavaProxyProperties branch January 29, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants