-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Environment Proxy Configurations #7593
Merged
alzimmermsft
merged 19 commits into
Azure:master
from
alzimmermsft:AzCore_SupportJavaProxyProperties
Jan 29, 2020
Merged
Add Support for Environment Proxy Configurations #7593
alzimmermsft
merged 19 commits into
Azure:master
from
alzimmermsft:AzCore_SupportJavaProxyProperties
Jan 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srnagar
approved these changes
Jan 24, 2020
...ure-core-http-netty/src/main/java/com/azure/core/http/netty/NettyAsyncHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/http/ProxyOptions.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/http/ProxyOptions.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/http/ProxyOptions.java
Outdated
Show resolved
Hide resolved
@srnagar I replied to your comments if you want to do another quick pass. |
...ure-core-http-netty/src/main/java/com/azure/core/http/netty/NettyAsyncHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...-core-http-okhttp/src/main/java/com/azure/core/http/okhttp/OkHttpAsyncHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...-core-http-okhttp/src/main/java/com/azure/core/http/okhttp/OkHttpAsyncHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/http/ProxyOptions.java
Outdated
Show resolved
Hide resolved
JonathanGiles
approved these changes
Jan 28, 2020
This was referenced Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Netty and OkHttp
HttpClient
s to check the environment for proxy configuration if theProxyOptions
set in their builder isnull
. Additionally, added the ability to set theConfiguration
object that the builders will use when retrieving proxy information from the environment.Environment proxy configurations will be loaded in the following order:
Azure proxy configurations are preferred over the Java proxy configurations as they relate more closely to the SDKs, additionally HTTPS is preferred over HTTP as it is more secure. Java proxies will require
java.net.useSystemProxies
to betrue
before that proxy configuration is applied.