Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TextSentimentClass to extend ExpandableStringEnum #7427

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Update TextSentimentClass to extend ExpandableStringEnum #7427

merged 1 commit into from
Jan 15, 2020

Conversation

samvaity
Copy link
Member

@samvaity samvaity commented Jan 14, 2020 •
edited
Loading

Update TextSentimentClass to extend ExpandableStringEnum to accommodate additive future changes to this enum.

Closes: #6962

@samvaity samvaity requested a review from mssfang as a code owner January 14, 2020 23:39
@samvaity samvaity self-assigned this Jan 14, 2020
@samvaity samvaity changed the title Update TextSentimentClass to be expandable enum Update TextSentimentClass to extend ExpandableStringEnum Jan 14, 2020
mssfang
mssfang approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@mssfang mssfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samvaity samvaity merged commit 44cc9c4 into Azure:master Jan 15, 2020
@samvaity samvaity deleted the ta-enum branch September 17, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssfang mssfang mssfang approved these changes

@joshfree joshfree Awaiting requested review from joshfree

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@kristapratico kristapratico Awaiting requested review from kristapratico

@annelo-msft annelo-msft Awaiting requested review from annelo-msft

Assignees

@samvaity samvaity

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] should TextSentimentClass need to be expandable
2 participants
@samvaity @mssfang