Update documentation and in-memory checkpoint store sample #7389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conniey
approved these changes
Jan 13, 2020
| @@ -103,6 +99,6 @@ public LastEnqueuedEventProperties getLastEnqueuedEventProperties() { | |||
| * successfully processed event in this partition if the update is successful. | |||
| */ | |||
| public void updateCheckpoint() { | |||
| this.updateCheckpointAsync(eventData).block(); | |||
| this.updateCheckpointAsync().block(); | |||
There was a problem hiding this comment.
for the .block(), should we pass in the "retryOptions.operationTimeout" so it doesn't block forever (or I think default is 5 mins)?
There was a problem hiding this comment.
Since this is just a delegate method to the checkpoint store's updateCheckpoint(), I think the checkpoint store (blob client or any other store) should be configured with the necessary timeouts and retry options. If the store they use is super-slow, they might want a different timeout setting than the one they use for Event Hubs (in retryOptions).
Maybe we can defer adding a timeout to a later release if that's required.
|
/check-enforcer reset |
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating some documentation and in-memory checkpoint store implementation to support multiple namespaces.