-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements a slf4j logger impl as default logger in azure core #7298
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ae1e40a
Address comments
sima-zhu cd8b2be
Unified logger APIs
sima-zhu e484e10
Fixed failed tests
sima-zhu 75bde91
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …
sima-zhu f3673e2
Addressed comments
sima-zhu 5f0f82b
Some more changes
sima-zhu f1a75a7
Remove some extra methods
sima-zhu 343ab84
Remove redundant checkstyle suppression
sima-zhu 49be4b3
Update DefaultLogger.java
sima-zhu 7258f76
Implements all APIs
sima-zhu 7145d10
Merge branch 'addlogimpl' of https://github.com/sima-zhu/azure-sdk-fo…
sima-zhu a0e582c
Fixed linting issue
sima-zhu 68085b4
Address feedback
sima-zhu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 0 additions & 30 deletions
30
sdk/core/azure-core/src/main/java/com/azure/core/implementation/LoggingUtil.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that all methods are implemented in
DefaultLogger
this exception is no longer required.