Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Complete Test Matrix in Storage #7251

Merged
merged 3 commits into from
Jan 8, 2020
Merged

Enable Complete Test Matrix in Storage #7251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
123a807
Removed Storage tests.yml matrix override to enable complete test matrix
alzimmermsft Jan 7, 2020
2db9aa9
Change windowUntil to use magic number
alzimmermsft Jan 8, 2020
f8718ce
Update windowUntil fetch limit comment
alzimmermsft Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobAsyncClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,11 +430,11 @@ private Mono<Response<BlockBlobItem>> determineUploadFullOrChunked(final Flux<By
}
/*
* Use cutBefore = true as we want to window all data under 4MB into one window.
* Set the prefetch to the maxSingleUploadSize in the case that there are numerous tiny buffers,
* windowUntil uses a default limit of 256 and once that is hit it will trigger onComplete which causes
* downstream issues.
* Set the prefetch to 'Integer.MAX_VALUE' to leverage an unbounded fetch limit in case there are numerous
* tiny buffers, windowUntil uses a default limit of 256 and once that is hit it will trigger onComplete
* which causes downstream issues.
*/
}, true, parallelTransferOptions.getMaxSingleUploadSize())
}, true, Integer.MAX_VALUE)
.buffer(2)
.next()
.flatMap(fluxes -> {
Expand Down
6 changes: 0 additions & 6 deletions sdk/storage/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@ trigger: none
jobs:
- template: ../../eng/pipelines/templates/jobs/archetype-sdk-tests.yml
parameters:
Matrix:
Windows - Java 8:
OSName: 'Windows'
OSVmImage: 'windows-2019'
JavaVersion: '1.8'
DisplayName: 'Windows - Java 8'
ServiceDirectory: storage
EnvVars:
AZURE_TEST_MODE: LIVE
Expand Down