Enable Complete Test Matrix in Storage #7251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - storage - tests |
|
Azure Pipelines failed to run 1 pipeline(s). |
mikeharder
approved these changes
Jan 8, 2020
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobAsyncClient.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
matrixconfiguration in thetests.ymlfile for Storage. This triggers Storage tests to inherit the test matrix from the parent template which specifies the complete testing matrix (Linux, Windows, and Mac X Java 8 and 11 [LTS]).Additionally, changes the
windowUntilprefetch frommaxSingleUploadSizetoInteger.MAX_VALUEto leverage an unbounded feature in Reactor. Previously, there was an issue that arose when the stream completed before triggering a window to be generated which lead to a deadlock/infinite loop state which hung the application, this was remedied by setting the prefetch limit to an arbitrarily high number. Recently it was discovered that this limit would generate anObjectarray the size of the limit, usingInteger.MAX_VALUEtriggers a specialized unbounded scenario where the prefetch is unlimited but doesn't generate the array. This change continues to fix the initially found issue while reducing the memory overhead introduced by creating the array.