Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KV version updates Jan 2020 #7144

Merged
merged 4 commits into from
Jan 7, 2020
Merged

KV version updates Jan 2020 #7144

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7182ca
version updates
g2vinay Jan 6, 2020
2564ab0
Merge branch 'master' into KV-version-updates-jan-2020
g2vinay Jan 6, 2020
f756a4c
version updates
g2vinay Jan 7, 2020
a88abea
update spotbugs pom.
g2vinay Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions eng/jacoco-test-coverage/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,17 @@
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-certificates</artifactId>
<version>4.0.0-beta.8</version> <!-- {x-version-update;com.azure:azure-security-keyvault-certificates;current} -->
<version>4.0.0</version> <!-- {x-version-update;com.azure:azure-security-keyvault-certificates;current} -->
</dependency>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-keys</artifactId>
<version>4.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-security-keyvault-keys;current} -->
<version>4.0.2</version> <!-- {x-version-update;com.azure:azure-security-keyvault-keys;current} -->
</dependency>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-secrets</artifactId>
<version>4.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-security-keyvault-secrets;current} -->
<version>4.0.2</version> <!-- {x-version-update;com.azure:azure-security-keyvault-secrets;current} -->
</dependency>
<dependency>
<groupId>com.azure</groupId>
Expand Down
6 changes: 3 additions & 3 deletions eng/spotbugs-aggregate-report/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,17 +210,17 @@
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-certificates</artifactId>
<version>4.0.0-beta.8</version> <!-- {x-version-update;com.azure:azure-security-keyvault-certificates;current} -->
<version>4.0.0</version> <!-- {x-version-update;com.azure:azure-security-keyvault-certificates;current} -->
</dependency>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-keys</artifactId>
<version>4.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-security-keyvault-keys;current} -->
<version>4.0.2</version> <!-- {x-version-update;com.azure:azure-security-keyvault-keys;current} -->
</dependency>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-secrets</artifactId>
<version>4.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-security-keyvault-secrets;current} -->
<version>4.0.2</version> <!-- {x-version-update;com.azure:azure-security-keyvault-secrets;current} -->
</dependency>
<dependency>
<groupId>com.azure</groupId>
Expand Down
6 changes: 3 additions & 3 deletions eng/versioning/version_client.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ com.azure:azure-e2e;1.0.0-beta.1;1.0.0-beta.1
com.azure:azure-identity;1.0.1;1.1.0-beta.1
com.azure:azure-messaging-eventhubs;5.0.0-beta.6;5.0.1
com.azure:azure-messaging-eventhubs-checkpointstore-blob;1.0.0-beta.4;1.0.1
com.azure:azure-security-keyvault-certificates;4.0.0-beta.7;4.0.0-beta.8
com.azure:azure-security-keyvault-keys;4.0.1;4.1.0-beta.1
com.azure:azure-security-keyvault-secrets;4.0.1;4.1.0-beta.1
com.azure:azure-security-keyvault-certificates;4.0.0-beta.7;4.0.0
com.azure:azure-security-keyvault-keys;4.0.1;4.0.2
com.azure:azure-security-keyvault-secrets;4.0.1;4.0.2
com.azure:azure-sdk-template;1.0.4-beta.2;1.0.4-beta.2
com.azure:azure-storage-blob;12.2.0-beta.1;12.2.0-beta.2
com.azure:azure-storage-blob-batch;12.1.0;12.2.0-beta.1
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/azure-core-tracing-opencensus/src/samples/AsyncListKeyVaultSecrets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Sample uses **[opencensus-impl][opencensus_impl]** as implementation package and
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-secrets</artifactId>
<version>4.1.0-beta.1</version>
<version>4.0.2</version>
</dependency>
```
[//]: # ({x-version-update-end})
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/azure-core-tracing-opencensus/src/samples/ListeKeyVaultSecrets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Sample uses **[opencensus-impl][opencensus_impl]** as implementation package and
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-secrets</artifactId>
<version>4.1.0-beta.1</version>
<version>4.0.2</version>
</dependency>
```
[//]: # ({x-version-update-end})
Expand Down
2 changes: 1 addition & 1 deletion .../azure-core-tracing-opentelemetry/src/samples/AsyncListKeyVaultSecretsSample.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Sample uses **[opentelemetry-sdk][opentelemetry_sdk]** as implementation package
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-secrets</artifactId>
<version>4.1.0-beta.1</version>
<version>4.0.2</version>
</dependency>
```
[//]: # ({x-version-update-end})
Expand Down
2 changes: 1 addition & 1 deletion ...zure-core-tracing-opentelemetry/src/samples/ListKeyVaultSecretsTracingSample.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Sample uses **[opentelemetry-sdk][opentelemetry_sdk]** as implementation package
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-secrets</artifactId>
<version>4.1.0-beta.1</version>
<version>4.0.2</version>
</dependency>
```
[//]: # ({x-version-update-end})
Expand Down
6 changes: 3 additions & 3 deletions sdk/e2e/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,17 @@
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-keys</artifactId>
<version>4.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-security-keyvault-keys;current} -->
<version>4.0.2</version> <!-- {x-version-update;com.azure:azure-security-keyvault-keys;current} -->
</dependency>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-secrets</artifactId>
<version>4.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-security-keyvault-secrets;current} -->
<version>4.0.2</version> <!-- {x-version-update;com.azure:azure-security-keyvault-secrets;current} -->
</dependency>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-certificates</artifactId>
<version>4.0.0-beta.8</version> <!-- {x-version-update;com.azure:azure-security-keyvault-certificates;current} -->
<version>4.0.0</version> <!-- {x-version-update;com.azure:azure-security-keyvault-certificates;current} -->
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/azure-security-keyvault-certificates/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Maven dependency for Azure Key Client library. Add it to your project's pom file
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-certificates</artifactId>
<version>4.0.0-beta.8</version>
<version>4.0.0</version>
</dependency>
```
[//]: # ({x-version-update-end})
Expand All @@ -34,7 +34,7 @@ Netty and include OkHTTP client in your pom.xml.
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-certificates</artifactId>
<version>4.0.0-beta.8</version>
<version>4.0.0</version>
<exclusions>
<exclusion>
<groupId>com.azure</groupId>
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/azure-security-keyvault-certificates/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-certificates</artifactId>
<version>4.0.0-beta.8</version> <!-- {x-version-update;com.azure:azure-security-keyvault-certificates;current} -->
<version>4.0.0</version> <!-- {x-version-update;com.azure:azure-security-keyvault-certificates;current} -->

<name>Microsoft Azure client library for KeyVault Certificates</name>
<description>This module contains client library for Microsoft Azure KeyVault Certificates.</description>
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/azure-security-keyvault-keys/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Maven dependency for Azure Key Client library. Add it to your project's pom file
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-keys</artifactId>
<version>4.1.0-beta.1</version>
<version>4.0.2</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may need a minor version bump instead of patch version bump since you are updating core to a version that has minor version bump.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That already happened in 4.0.1 https://search.maven.org/artifact/com.azure/azure-security-keyvault-keys/4.0.1/jar. In either case I don't think that new dependency necessary requires a minor version bump, see https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api which has some info on this case.

Copy link
Member

@srnagar srnagar Jan 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most cases, updating dependency without changing public API doesn't require a minor version bump. However, if the underlying dependency upgrades result in a significantly different behavior, then it's worth bumping the minor version of this library too.

In this case, core has several changes that impact how the KV APIs behave. For e.g. iterable stream now lazily fetches pages instead of eagerly fetching all pages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fair if the behavior is detectable by consumers of KV library as a new behavior then you should bump the minor version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor version bumped.

</dependency>
```
[//]: # ({x-version-update-end})
Expand All @@ -35,7 +35,7 @@ Netty and include OkHTTP client in your pom.xml.
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-keys</artifactId>
<version>4.1.0-beta.1</version>
<version>4.0.2</version>
<exclusions>
<exclusion>
<groupId>com.azure</groupId>
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/azure-security-keyvault-keys/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-keys</artifactId>
<version>4.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-security-keyvault-keys;current} -->
<version>4.0.2</version> <!-- {x-version-update;com.azure:azure-security-keyvault-keys;current} -->

<name>Microsoft Azure client library for KeyVault Keys</name>
<description>This module contains client library for Microsoft Azure KeyVault Keys.</description>
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/azure-security-keyvault-secrets/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Maven dependency for Azure Secret Client library. Add it to your project's pom f
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-secrets</artifactId>
<version>4.1.0-beta.1</version>
<version>4.0.2</version>
</dependency>
```
[//]: # ({x-version-update-end})
Expand All @@ -36,7 +36,7 @@ Netty and include OkHTTP client in your pom.xml.
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-secrets</artifactId>
<version>4.1.0-beta.1</version>
<version>4.0.2</version>
<exclusions>
<exclusion>
<groupId>com.azure</groupId>
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/azure-security-keyvault-secrets/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<groupId>com.azure</groupId>
<artifactId>azure-security-keyvault-secrets</artifactId>
<version>4.1.0-beta.1</version> <!-- {x-version-update;com.azure:azure-security-keyvault-secrets;current} -->
<version>4.0.2</version> <!-- {x-version-update;com.azure:azure-security-keyvault-secrets;current} -->

<name>Microsoft Azure client library for KeyVault Secrets</name>
<description>This module contains client library for Microsoft Azure KeyVault Secrets.</description>
Expand Down