[After MSAL 1.3] Pluggable HTTP in identity/msal #7120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's hold this back until MSAL 1.3.0 is released with it's significantly reduced dependency set. |
JimSuplizio
reviewed
Jan 7, 2020
| @@ -62,7 +62,7 @@ com.microsoft.azure:azure-mgmt-keyvault;1.11.1 | |||
| com.microsoft.azure:azure-mgmt-resources;1.3.0 | |||
| com.microsoft.azure:azure-mgmt-storage;1.3.0 | |||
| com.microsoft.azure:azure-storage;8.0.0 | |||
| com.microsoft.azure:msal4j;0.5.0-preview | |||
| com.microsoft.azure:msal4j;1.1.0 | |||
There was a problem hiding this comment.
I like that this is moving past a preview version.
JimSuplizio
approved these changes
Jan 7, 2020
|
Bump version to 1.3.0 on Jan 10 before merging |
g2vinay
reviewed
Jan 13, 2020
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Show resolved
Hide resolved
...tity/azure-identity/src/test/java/com/azure/identity/implementation/IdentityClientTests.java
Outdated
Show resolved
Hide resolved
srnagar
reviewed
Jan 14, 2020
| @@ -76,7 +76,7 @@ | |||
| <dependency> | |||
| <groupId>com.microsoft.azure</groupId> | |||
| <artifactId>msal4j</artifactId> | |||
| <version>0.5.0-preview</version> <!-- {x-version-update;com.microsoft.azure:msal4j;external_dependency} --> | |||
| <version>1.3.0</version> <!-- {x-version-update;com.microsoft.azure:msal4j;external_dependency} --> | |||
There was a problem hiding this comment.
This is track 1 event hubs module. Did you intend to update msal version of track 1 module too? This might need service team's validation.
There was a problem hiding this comment.
Is this because you are using the script to update the external dependency version and it's updating both track 1 and track 2 dependencies?
|
/check-enforcer reset |
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.