Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving tests of azure-cosmos into separate module to allow using failure injection there #34207

Conversation

FabianMeiswinkel
Copy link
Member

Description

Moving tests of azure-cosmos into separate module to allow using failure injection there

Tests of azure-cosmos and optionally azure-cosmos-test will be in azure-cosmos-tests
azure-cosmos-tests will not be published to Maven
azure-cosmos-test (failure injection) depends on azure-cosmos
azure-cosmos-tests (the azure-cosmos tests) depends on both azure-cosmos and azure-cosmos-test)

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@FabianMeiswinkel
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@FabianMeiswinkel
Copy link
Member Author

/check-enforcer override

Test "IncrementalChangeFeedProcessorTest::readFeedDocumentsAfterSplit" passed locally and is known to be somewhat flaky.

@FabianMeiswinkel
Copy link
Member Author

/check-enforcer override

@FabianMeiswinkel FabianMeiswinkel merged commit 75db6bd into Azure:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants