Try removing sync stack context flag

[lmolkova]

No description provided.

[azure-sdk]

API change check

API changes are not detected in this pull request.

[lmolkova]

/azp run java - containerregistry - tests

[lmolkova]

/azp run java - monitor - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[g2vinay]

/azp run java - keyvault - ci

[azure-pipelines]

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

[g2vinay]

/azp run java - keyvault - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[alzimmermsft]

Why is this API override logging?

[lmolkova]

To make body logging synchronous: getBodyAsBinaryData is the only sync way to get the response body and default implementation is async

azure-sdk-for-java/sdk/core/azure-core/src/main/java/com/azure/core/http/HttpResponse.java

Lines 89 to 92 in 1cb5a6a

	public BinaryData getBodyAsBinaryData() {
	Flux<ByteBuffer> body = getBody();
	if (body != null) {
	return BinaryDataHelper.createBinaryData(new FluxByteBufferContent(body));

[srnagar]

Should we eagerly call content.toString() here? Instead we should consider passing the content to doLog() method and there, we can use the supplier methods ClientLogger provides to log if logging is enabled - logBuilder.addKeyValue(BODY_KEY, () -> content.toString()).

[lmolkova]

LoggingHttpResponse is created only if logging at that level is enabled, body logging is enabled and content type is not a stream, so there is no need to do lazy toString - there are no checks in doLog method.

azure-sdk-for-java/sdk/core/azure-core/src/main/java/com/azure/core/http/policy/HttpLoggingPolicy.java

Lines 300 to 315 in 4103846

	if (!logger.canLogAtLevel(logLevel)) {
	return response;
	}
	LoggingEventBuilder logBuilder = getLogBuilder(logLevel, logger);
	logContentLength(response, logBuilder);
	logUrl(loggingOptions, response, logBuilder);
	logHeaders(logger, response, logBuilder);
	if (httpLogDetailLevel.shouldLogBody()) {
	String contentTypeHeader = response.getHeaderValue("Content-Type");
	long contentLength = getContentLength(logger, response.getHeaders());
	if (shouldBodyBeLogged(contentTypeHeader, contentLength)) {
	return new LoggingHttpResponse(response, logBuilder, logger,

[lmolkova]

/azp run java - keyvault - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[samvaity]

Changes lgtm!

[srnagar]

Should we eagerly call content.toString() here? Instead we should consider passing the content to doLog() method and there, we can use the supplier methods ClientLogger provides to log if logging is enabled - logBuilder.addKeyValue(BODY_KEY, () -> content.toString()).