Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Config Spring Feature Flag Updates #34149

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Conversation

mrm9084
Copy link
Member

@mrm9084 mrm9084 commented Mar 21, 2023

Description

  • Updates Arch Review Board Changes for feature Flags
  • Fixes Bug where Feature Flag Refresh with multiple key labels would always happen
  • Fixes Bug where refresh check didn't use prefix value for feature flags, so they were never requested when using key filter.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the azure-spring All azure-spring related issues label Mar 21, 2023
@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 21, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-feature-management

Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun chenrujun merged commit c602ac6 into Azure:main Mar 22, 2023
@mrm9084 mrm9084 deleted the PredicateTest branch March 22, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants