Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling when there is no NextRowKey in response header #34143

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

kellyyyyin
Copy link
Contributor

Description

There is an issue in java version tables SDK which is similar to this one: Azure/azure-sdk-for-net#19891
UT is not added since which might need some refactoring on method listEntitiesNextPage, let me know if you think UT is needed here.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 21, 2023
@ghost
Copy link

ghost commented Mar 21, 2023

Thank you for your contribution kellyyyyin! We will review the pull request and get back to you soon.

The build was failing for checkstyle violations. This adjustment should fix them.
@kellyyyyin
Copy link
Contributor Author

kellyyyyin commented Mar 22, 2023 via email

Copy link
Member

@jairmyree jairmyree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good to me. I'm going to create an additional PR to refactor some logic and add additional tests into the repo.

@jairmyree jairmyree merged commit 40e0f0b into Azure:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants