Supporting encrypted upload for EncryptedBlobClient.upload(InputStream) with no length specified #34040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
alzimmermsft
approved these changes
Mar 22, 2023
sdk/storage/azure-storage-common/src/main/java/com/azure/storage/common/Utility.java
Outdated
Show resolved
Hide resolved
alzimmermsft
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #32657
EncryptedBlobAsyncClient.upload()APIs could not support uploadingInputStreamif length was not specified and cause null pointer exception sinceBlobParallelUploadOptions.getLength()would return null.Now adding checks (same logic as in BlobAsyncClient) for whether length is passed along with
InputStream, and if not then we convert the Stream to aFlux<ByteBuffer>which will then be encrypted before uploading.