Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt core, add MANAGED_HSM to AzureEnvironment #34006

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Mar 14, 2023

Description

azure-core-management preparation for #33659

control plane endpoints: https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/control-plane-and-data-plane#control-plane

AzureEnvironment.AZURE: https://management.azure.com/metadata/endpoints?api-version=latest
AzureEnvironment.AZURE_CHINA: https://management.chinacloudapi.cn/metadata/endpoints?api-version=latest
AzureEnvironment.AZURE_US_GOVERNMENT: https://management.usgovcloudapi.net/metadata/endpoints?api-version=latest

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Azure.Core azure-core label Mar 14, 2023
@XiaofeiCao XiaofeiCao added the Mgmt This issue is related to a management-plane library. label Mar 14, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core-management

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wait for core owner to review.

@XiaofeiCao
Copy link
Contributor Author

XiaofeiCao commented Mar 17, 2023

Hi @alzimmermsft @srnagar Please help review the PR. We want it to catch up with next core release. Thanks!

@XiaofeiCao XiaofeiCao merged commit f2c5aec into Azure:main Mar 22, 2023
@XiaofeiCao
Copy link
Contributor Author

Thanks Srikanta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants