Communication Identity | Coverage improvement #33896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run java - azure-communication-identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
/azp run java - azure-communication-identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - azure-communication-identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alzimmermsft
approved these changes
Mar 8, 2023
...ntity/src/main/java/com/azure/communication/identity/CommunicationIdentityClientBuilder.java
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-identity/swagger/README.md
Outdated
Show resolved
Hide resolved
|
/azp run java - azure-communication-identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
petrsvihlik
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On discussion with the SDK Engineering folks, it was finalized that we must include Autorest code in the coverage report and adjust Autorest configuration.
So, made some improvements in Autorest configuration to reduce/optimize unused generated code and also add some test cases for files that were not covered as a part of tests.
Also, updated ReadMe file for Autorest that simplifies command to run code generation in general.
Coverage : 92% (once CTE Tests are enabled in PPE & INT)
Discussion with the SDK Engineering folks :
Maqsood Jafferi: Excluding Autorest (Autogenerated) code from Coverage Report
User Story : [Pipeline][Identity][JAVA] Test coverage improvement
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines