Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Purview Share Java SDK Version 2023-02-15-preview (Client, Tests, Samples) #33719

Merged

Conversation

kevinmichaelbowersox
Copy link
Member

Microsoft Purview Share Java SDK Version 2023-02-15-Preview

Description

This PR introduces the SDK Client, tests and examples for the Microsoft Purview Share SDK version 2023-02-15-preview. The API Specification for this version of the service was approved in this pull request.

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@kevinmichaelbowersox kevinmichaelbowersox changed the title Microsoft Purview Sharee Java SDK Version 2023-02-15-preview (Client, Tests, Samples) Microsoft Purview Share Java SDK Version 2023-02-15-preview (Client, Tests, Samples) Feb 24, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-analytics-purview-sharing

@kevinmichaelbowersox
Copy link
Member Author

kevinmichaelbowersox commented Feb 24, 2023

@srnagar @conniey @alzimmermsft @JonathanGiles When you have a moment, could you please review?

Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments about the CHANGELOG and headers... otherwise, looks great!

Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing samples/readme, other changes lgtm!

@samvaity samvaity merged commit 31b4310 into Azure:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants