-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft Purview Share Java SDK Version 2023-02-15-preview (Client, Tests, Samples) #33719
Microsoft Purview Share Java SDK Version 2023-02-15-preview (Client, Tests, Samples) #33719
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
@srnagar @conniey @alzimmermsft @JonathanGiles When you have a moment, could you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments about the CHANGELOG and headers... otherwise, looks great!
...tics-purview-sharing/src/samples/java/com/azure/analytics/purview/sharing/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...-purview-sharing/src/test/java/com/azure/analytics/purview/sharing/PurviewShareTestBase.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing samples/readme, other changes lgtm!
Microsoft Purview Share Java SDK Version 2023-02-15-Preview
Description
This PR introduces the SDK Client, tests and examples for the Microsoft Purview Share SDK version 2023-02-15-preview. The API Specification for this version of the service was approved in this pull request.
[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines