Clarify Key Vaults properties for Spring Cloud Azure #33675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
saragluna
reviewed
Feb 23, 2023
| */ | ||
| private boolean caseSensitive = false; | ||
| /** | ||
| * The secret keys supported for this property source. | ||
| * The configured secret keys will be loaded from Azure Key Vaults secret, if configured nothing, then load all the secrets. |
There was a problem hiding this comment.
Do we need to mention the format here? Will it use the exact secret names stored in the KV or using Spring format?
There was a problem hiding this comment.
I think you get the point, we definitely should provide such info, or customer may wonder what key they should provide to this property
saragluna
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Fixes: #29578