eng, fix for disabled jacoco in DPG/Cadl #33516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. azure-security-confidentialledger |
|
/azp run java - confidentialledger |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - purview |
|
Azure Pipelines successfully started running 1 pipeline(s). |
26e3116 to
9024809
Compare
|
/azp run java - purview |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - confidentialledger |
|
Azure Pipelines successfully started running 1 pipeline(s). |
haolingdong-msft
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable jacoco for DPG/Cadl lib, with some
jacoco.minwhen current coverage is insufficient.In future, autorest.java or cadl-java will not generate pom with
jacoco.skip=trueAzure/autorest.java#1979We'd expect CI to fail on new DPG/Cadl SDK without test (DPG generates disabled test for service reference).
We will add CI troubleshoot in quickstart doc to let service know that they can add
jacoco.min.linecoverageto pom if their SDK is beta. But we'd expect higher coverage on their GA SDK.https://github.com/Azure/azure-sdk-for-java/wiki/Cadl-Java-Quickstart#run-tests-for-from-source-run
report:
loadtesting and devcenter already has jacoco enabled.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines