Adding new flag for not having the CosmosIndexingPolicy override. #33171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is in portal, with all the tests and documentation changes needed with it.
kushagraThapar
requested changes
Jan 26, 2023
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/IndexingPolicy.java
Outdated
Show resolved
Hide resolved
...ata-cosmos/src/main/java/com/azure/spring/data/cosmos/core/mapping/CosmosIndexingPolicy.java
Outdated
Show resolved
Hide resolved
...ata-cosmos/src/main/java/com/azure/spring/data/cosmos/core/mapping/CosmosIndexingPolicy.java
Outdated
Show resolved
Hide resolved
Updating wording. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>
Updating wording. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>
Updating wording. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>
Updating wording. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
…BridgeHelpers as they are only needed for Spring.
…ring/data/cosmos/core/mapping/CosmosIndexingPolicy.java Updating wording. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>
…o trande_CosmosIndexingPolicy
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer evaluate |
|
/azp run java - cosmos - tests |
|
/check-enforcer evaluate |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
/check-enforcer evaluate |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
/check-enforcer evaluate |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new flag for not having the CosmosIndexingPolicy override what is in portal, with all the tests and documentation changes needed with it.
This is a breaking change because under the current functionality, the
CosmosIndexingPolicydefined on a container overwrites what is in portal or while deploying an update of the Spring app containing changes to the index policy overwrites between the competing versions of the application. However, under the new implementation we will not overwrite the index policy for existing containers unless the flag 'overwritePolicyis manually set to true by the user on theCosmosIndexingPolicy` (the default is false). This breaking change is introduced because the competing updates to the index policy can have sever livesite implication.If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines