Onboard ingestion onto sync stack #33146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lmolkova
commented
Jan 23, 2023
- update swagger
- move common (between sync and async) code to utils
- implement concurrency for async and sync clients
...src/main/java/com/azure/monitor/ingestion/implementation/ConcurrencyLimitingSpliterator.java
Outdated
Show resolved
Hide resolved
9e62547 to
b2760fb
Compare
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
5469a4b to
653f5aa
Compare
|
/azp run java - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
srnagar
reviewed
Mar 10, 2023
...re-monitor-ingestion/src/main/java/com/azure/monitor/ingestion/LogsIngestionAsyncClient.java
Outdated
Show resolved
Hide resolved
...r/azure-monitor-ingestion/src/main/java/com/azure/monitor/ingestion/LogsIngestionClient.java
Outdated
Show resolved
Hide resolved
...r/azure-monitor-ingestion/src/main/java/com/azure/monitor/ingestion/LogsIngestionClient.java
Outdated
Show resolved
Hide resolved
...r/azure-monitor-ingestion/src/main/java/com/azure/monitor/ingestion/LogsIngestionClient.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/azure/monitor/ingestion/implementation/ConcurrencyLimitingSpliterator.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/azure/monitor/ingestion/implementation/ConcurrencyLimitingSpliterator.java
Outdated
Show resolved
Hide resolved
.../azure-monitor-ingestion/src/main/java/com/azure/monitor/ingestion/implementation/Utils.java
Outdated
Show resolved
Hide resolved
812dd43 to
4d587f8
Compare
srnagar
reviewed
Mar 21, 2023
...src/main/java/com/azure/monitor/ingestion/implementation/ConcurrencyLimitingSpliterator.java
Outdated
Show resolved
Hide resolved
...zure-monitor-ingestion/src/main/java/com/azure/monitor/ingestion/implementation/Batcher.java
Outdated
Show resolved
Hide resolved
.../azure-monitor-ingestion/src/main/java/com/azure/monitor/ingestion/implementation/Utils.java
Outdated
Show resolved
Hide resolved
...zure-monitor-ingestion/src/main/java/com/azure/monitor/ingestion/implementation/Batcher.java
Outdated
Show resolved
Hide resolved
...zure-monitor-ingestion/src/main/java/com/azure/monitor/ingestion/implementation/Batcher.java
Outdated
Show resolved
Hide resolved
...zure-monitor-ingestion/src/main/java/com/azure/monitor/ingestion/implementation/Batcher.java
Show resolved
Hide resolved
5054f3c to
9f8ad1c
Compare
srnagar
approved these changes
Mar 22, 2023
| /** | ||
| * Provides iterator and streams for batches over log objects. | ||
| */ | ||
| public class Batcher implements Iterator<LogsIngestionRequest> { |
There was a problem hiding this comment.
This looks great! Having a common batcher for both sync and async client is very useful. When the batching logic is updated, both clients will have the same behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.