Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample for write #32614

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Add sample for write #32614

merged 1 commit into from
Mar 21, 2023

Conversation

arwinlashawn
Copy link
Contributor

Was using this README to do Cosmos DB data migration with Azure Databricks and realized the sample code for write was missing. I think adding this would greatly help anyone learning to use Databricks for Cosmos DB data migration!

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Was using this README to do Cosmos DB data migration with Azure Databricks and realized the sample code for write was missing. I think adding this would greatly help anyone learning to use Databricks for Cosmos DB data migration!
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @arwinlashawn for the contributions.
@FabianMeiswinkel can you please take a look as well?

@arwinlashawn
Copy link
Contributor Author

Thanks for the prompt review @kushagraThapar ! @FabianMeiswinkel Please let me know if any changes are needed.

@arwinlashawn
Copy link
Contributor Author

Hi @kushagraThapar , could you please take a look at this PR? Thanks!

@kushagraThapar
Copy link
Member

@xinlian12 / @FabianMeiswinkel - please take a look at this.

@arwinlashawn
Copy link
Contributor Author

Hi @xinlian12, could you please have a look at this PR? Thanks!

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabianMeiswinkel FabianMeiswinkel merged commit f4ec9b0 into Azure:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants