Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated blobs to the new generator #18907

Merged
merged 40 commits into from
Mar 19, 2021
Merged

Migrated blobs to the new generator #18907

merged 40 commits into from
Mar 19, 2021

Conversation

gapra-msft
Copy link
Member

No description provided.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Feb 1, 2021
gapra-msft
gapra-msft commented Feb 1, 2021
View reviewed changes
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/models/CpkInfo.java Outdated
*/
@JacksonXmlRootElement(localName = "cpk-info")
/** Parameter group. */
@JacksonXmlRootElement(localName = "CpkInfo")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this

gapra-msft
gapra-msft commented Feb 1, 2021
View reviewed changes
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/models/Block.java Outdated
*/
@Deprecated public int getSize() {
return (int) this.sizeLong;
public int getSizeInt() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix these 2 methods

gapra-msft
gapra-msft commented Feb 1, 2021
View reviewed changes
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/models/BlobHttpHeaders.java Outdated
*/
@JacksonXmlRootElement(localName = "blob-http-headers")
/** Parameter group. */
@JacksonXmlRootElement(localName = "BlobHttpHeaders")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this

gapra-msft
gapra-msft commented Feb 1, 2021
View reviewed changes
...re-storage-blob/src/main/java/com/azure/storage/blob/models/BlobContainerItemProperties.java
*/
@JsonProperty(value = "DenyEncryptionScopeOverride")
private boolean encryptionScopeOverridePrevented;
private Boolean encryptionScopeOverridePrevented;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this

gapra-msft
gapra-msft commented Feb 1, 2021
View reviewed changes
...e-storage-blob/src/main/java/com/azure/storage/blob/models/BlobContainerEncryptionScope.java Outdated
*/
@JacksonXmlRootElement(localName = "blob-container-encryption-scope")
/** Parameter group. */
@JacksonXmlRootElement(localName = "BlobContainerEncryptionScope")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this

@check-enforcer
Copy link

check-enforcer bot commented Feb 2, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

gapra-msft
gapra-msft commented Feb 4, 2021
View reviewed changes
...torage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobContainerAsyncClient.java
this.serviceVersion = serviceVersion;

this.accountName = accountName;
this.containerName = containerName;
this.customerProvidedKey = customerProvidedKey;
this.encryptionScope = encryptionScope;
this.blobContainerEncryptionScope = blobContainerEncryptionScope;
/* Check to make sure the uri is valid. We don't want the error to occur later in the generated layer
when the sas token has already been applied. */
try {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Move all these checks to end

@gapra-msft gapra-msft requested a review from mssfang as a code owner February 25, 2021 19:58
@gapra-msft
Copy link
Member Author

/azp run java - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gapra-msft
Copy link
Member Author

/azp run java - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gapra-msft
Copy link
Member Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gapra-msft
Copy link
Member Author

/azp run java - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gapra-msft
Copy link
Member Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gapra-msft gapra-msft mentioned this pull request Mar 16, 2021
Closed
1 task
@gapra-msft
Copy link
Member Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gapra-msft
Copy link
Member Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gapra-msft gapra-msft merged commit 111c8e7 into Azure:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickle-msft rickle-msft rickle-msft approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@kasobol-msft kasobol-msft Awaiting requested review from kasobol-msft

@mssfang mssfang Awaiting requested review from mssfang

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gapra-msft @rickle-msft