Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment version for keyvault releases #18748

Merged

Conversation

azure-sdk
Copy link
Collaborator

Increment package version after release of com.azure azure-security-keyvault-jca

@@ -1,5 +1,8 @@
# Release History

## 1.0.0-beta.4 (Unreleased)


## 1.0.0-beta.3 (2021-01-20)

Copy link
Member

@vcolin7 vcolin7 Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update library changelogs (even for dependency updates) for each release.

//cc @jialindai

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcolin7 . Thank you for your check. I updated the changelog.

@@ -4,6 +4,8 @@


## 1.0.0-beta.3 (2021-01-20)
- Fix NPE: https://github.com/Azure/azure-sdk-for-java/issues/17953
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should give a clear outline of each change log instead of list links to github issues. Besides, please follow the specification of release notes and add proper section headers.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiliuTo , thank you for your suggestion. I updated it.

Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenrujun chenrujun merged commit 76ce32c into Azure:master Jan 27, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Apr 21, 2022
desktopvirtualization: generating the 2022-02 sdk (Azure#18748)

Co-authored-by: Alex Wilcox <alex.wilcox@cloudsecure.ltd>
@azure-sdk azure-sdk deleted the increment-package-version-keyvault-695593 branch October 18, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants