-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increment version for keyvault releases #18748
Increment version for keyvault releases #18748
Conversation
@@ -1,5 +1,8 @@ | |||
# Release History | |||
|
|||
## 1.0.0-beta.4 (Unreleased) | |||
|
|||
|
|||
## 1.0.0-beta.3 (2021-01-20) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update library changelogs (even for dependency updates) for each release.
//cc @jialindai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vcolin7 . Thank you for your check. I updated the changelog.
@@ -4,6 +4,8 @@ | |||
|
|||
|
|||
## 1.0.0-beta.3 (2021-01-20) | |||
- Fix NPE: https://github.com/Azure/azure-sdk-for-java/issues/17953 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should give a clear outline of each change log instead of list links to github issues. Besides, please follow the specification of release notes and add proper section headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yiliuTo , thank you for your suggestion. I updated it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
desktopvirtualization: generating the 2022-02 sdk (Azure#18748) Co-authored-by: Alex Wilcox <alex.wilcox@cloudsecure.ltd>
Increment package version after release of com.azure azure-security-keyvault-jca