Fix contract on Key Vault broken with premature merge #17741

[edburns]

On branch edburns-msft-18273-keyvault-certificates-properties WIP on #18273 property name consistency

This commit addresses the damage apparently done by the apparently prematurely merged #17741. That PR was seeking conceptual review in the associated issue #17740 (see this comment). While I received the conceptual review, I had not yet completed the corresponding implementation work.

This commit does not complete that work either. However, it does make
the system work again, but only with property names that strictly
conform to the "hyphens not camel case" syntax.

Before this commit, the system did not work at all.

After this commit, the system works, but only with the new conforming
properties, which means it will break existing customers.

I am continuing to work on #18273, which will make the system work
without breaking existing customers.

modified: sdk/keyvault/azure-security-keyvault-jca/README.md
modified: sdk/keyvault/azure-security-keyvault-jca/pom.xml

• Several tests were using non-conforming test property names, such as:

  • System.getProperty("azure.tenant.id"),
  • System.getProperty("azure.client.id"),
  • System.getProperty("azure.client.secret"));

  I changed these to

  • System.getProperty("azure.keyvault.tenant-id"),
  • System.getProperty("azure.keyvault.client-id"),
  • System.getProperty("azure.keyvault.client-secret"));

modified: sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java

• This is where the damage happened. When On branch edburns-msft-17740-keyvault-certificates-properties Fixes #17740 #17741 was merged, those
  changes invalidated the contract with this code. This change
  modifies this side of the contract to conform with that in the
  existing On branch edburns-msft-17740-keyvault-certificates-properties Fixes #17740 #17741 change.

modified: sdk/keyvault/azure-security-keyvault-jca/src/samples/java/sample/com/azure/security/keyvault/jca/ClientSSLSample.java
modified: sdk/keyvault/azure-security-keyvault-jca/src/samples/java/sample/com/azure/security/keyvault/jca/ServerSSLSample.java
modified: sdk/keyvault/azure-security-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/AuthClientTest.java
modified: sdk/keyvault/azure-security-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultJcaProviderTest.java
modified: sdk/keyvault/azure-security-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyStoreTest.java
modified: sdk/keyvault/azure-security-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultLoadStoreParameterTest.java
modified: sdk/keyvault/azure-security-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/ServerSocketTest.java
modified: sdk/spring/azure-spring-boot-samples/azure-spring-boot-sample-keyvault-certificates/pom.xml
modified: sdk/spring/azure-spring-boot-samples/azure-spring-boot-sample-keyvault-certificates/src/main/resources/application.properties

• These changes all bring the samples and tests into sync with the new contract.

[chenrujun]

LGTM.