mgmt core Region #14470
Merged
mgmt core Region #14470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xseeseesee
approved these changes
Aug 26, 2020
ChenTanyi
approved these changes
Aug 26, 2020
|
@srnagar Let me know if any feedback or recommendation. |
sdk/core/azure-core-management/src/main/java/com/azure/core/management/Region.java
Outdated
Show resolved
Hide resolved
ChenTanyi
approved these changes
Sep 1, 2020
srnagar
reviewed
Sep 3, 2020
sdk/core/azure-core-management/src/main/java/com/azure/core/management/Region.java
Show resolved
Hide resolved
sdk/core/azure-core-management/src/main/java/com/azure/core/management/Region.java
Show resolved
Hide resolved
| */ | ||
| public static Region[] values() { | ||
| Collection<Region> valuesCollection = VALUES_BY_NAME.values(); | ||
| return valuesCollection.toArray(new Region[valuesCollection.size()]); |
There was a problem hiding this comment.
Why not return the collection itself instead of converting it to array?
There was a problem hiding this comment.
It is kind of emulate Enum public static T[] values().
Sure to change to Collection (as https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/core/azure-core/src/main/java/com/azure/core/util/ExpandableStringEnum.java#L72-L74).
| @@ -32,6 +32,7 @@ | |||
| public static final Region CANADA_CENTRAL = new Region("canadacentral", "Canada Central"); | |||
| public static final Region CANADA_EAST = new Region("canadaeast", "Canada East"); | |||
| public static final Region BRAZIL_SOUTH = new Region("brazilsouth", "Brazil South"); | |||
| public static final Region BRAZIL_SOUTHEAST = new Region("brazilsoutheast", "Brazil Southeast"); | |||
There was a problem hiding this comment.
Do we need another Region.java in azure-resourcemanager-resources? Can this just use the one in azure-core-management?
There was a problem hiding this comment.
If we add it in core-management, we will do the switch after next release.
srnagar
approved these changes
Sep 3, 2020
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put Region to azure-core-management, which is to be shared across mgmt SDKs.
Region is common to all mgmt Azure resources.
https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource
I am not sure whether this be in root namespace or better be a nested namespace (
models)?