Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending DeploymentOperationsImpl from ReadableWrappersIm… #1005

Merged
merged 2 commits into from
Aug 3, 2016
Merged

Extending DeploymentOperationsImpl from ReadableWrappersIm… #1005

merged 2 commits into from
Aug 3, 2016

Conversation

anuchandy
Copy link
Member

…pl, fixing #999 and adding DefinitionStages and UpdateStages interfaces to GenericResource

@anuchandy
Extending DeploymentOperationsImpl to extends from ReadableWrappersIm…
5739786 
…pl, fixing #999 and adding DefinitionStages and UpdateStages interfaces to GenericResource
@anuchandy anuchandy changed the title Extending DeploymentOperationsImpl to extends from ReadableWrappersIm… Extending DeploymentOperationsImpl from ReadableWrappersIm… Aug 2, 2016
@azurecla
Copy link

azurecla commented Aug 2, 2016

Hi @anuchandy, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

martinsawicki
martinsawicki reviewed Aug 2, 2016
View reviewed changes
...e-mgmt-resources/src/main/java/com/microsoft/azure/management/resources/GenericResource.java
*/
DefinitionWithApiVersion withoutPlan();
}
interface WithOrWithoutParentResource extends WithPlan {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the "OrWithout" part?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the comment, I think I understand the intent, but then why idn't WithPlan the next interface in the required chain (instead of WithOrWithoutParentResource) and then this interface (renamed as WithParentResource) simply becomes one of the optionals? (WithCreate)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point!, will update the PR.

@martinsawicki martinsawicki merged commit ae00855 into Azure:master Aug 3, 2016
@anuchandy anuchandy deleted the generic-resource branch February 8, 2017 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anuchandy @azurecla @azuresdkci @martinsawicki