Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Test: Replace long sleeps with polling #7353

Closed
mikeharder opened this issue Jan 10, 2020 · 1 comment
Closed

[Storage] Test: Replace long sleeps with polling #7353

mikeharder opened this issue Jan 10, 2020 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@mikeharder
Copy link
Member

When possible, tests should use polling with short sleeps instead of a single long sleep. Polling with short sleeps is better because tests run as quickly as possible, yet still have the flexibility to wait as long as necessary for things to reach the desired state. A single long sleep is worse because if it's too long it wastes time, and if it's too short it's unreliable.

@mikeharder mikeharder added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. labels Jan 10, 2020
@alzimmermsft
Copy link
Member

Closing this as the tests now run in parallel which reduces the amount of time wasted due to thread sleeping.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

2 participants