Fluent flow in VM::DataDisk

[anuchandy]

This is a thread for discussing the fluent definition flow for attaching multiple data disks (new/existing) to a virtual machine.

payload:

            "dataDisks": [
                {
                    "lun": 0,
                    "name": "disk1",
                    "createOption": "Empty",
                    "vhd": {
                        "uri": "https://<stg-account1>.blob.core.windows.net/vhds/<new-vhd>.vhd"
                    },
                    "caching": "None" | "ReadOnly" | "ReadWrite",
                    "diskSizeGB": <size>
                },
                {
                    "lun": 1,
                    "name": "disk2",
                    "createOption": "Attach",
                    "vhd": {
                        "uri": "https://<stg-account2>.blob.core.windows.net/vhds/<existing-vhd>.vhd"
                    },
                    "caching": "None" | "ReadOnly" | "ReadWrite",
                    "diskSizeGB": null
                }
            ]

uri: Url to vhd in ANY storage account in the subscription, there is no restriction that disk needs to store in the same account as OS disk. Different data-disk can be stored in different storage accounts. Assuming this helps to maximize the IOPS in the disk.

_Option-1_ [Requires inner class]

Grammar1 ::= ( 'withNewDataDisk(size)' | 'withExistingDataDisk(url)' | ( 'defineNewDataDisk(size)' ( 'withLun' | 'withName' | 'withCaching' | 'storeAt' )* | 'defineExistingDataDisk(url)' ( 'withLun' | 'withName' | 'withCaching' )* ) 'attach' )*

_Option-2_ [Inner class not required]

Grammar2 ::= ( 'withNewDataDisk(size)' | 'withExistingDataDisk(url)' | ( 'defineNewDataDisk(size)' 'storeAt'? | 'defineExistingDataDisk(url)' ) ( 'withLun' | 'withName' | 'withCaching' )* 'attach' )*

_Option-3_ [Inner class not required]

Grammar3 ::= ( 'withNewDataDisk(size)' | 'withExistingDataDisk(url)' | ( 'defineNewDataDisk()' 'withSize(size)' 'storeAt'? | 'defineExistingDataDisk()' 'use(url)' ) ( 'withLun' | 'withName' | 'withCaching' )* 'attach' )*

_Option-4_ [Requires inner class]

Grammar4 ::= ( 'withNewDataDisk(size)' | 'withExistingDataDisk(url)' | ( 'defineNewDataDisk()' 'withSize(size)' ( 'withLun' | 'withName' | 'withCaching' | 'storeAt' )* | 'defineExistingDataDisk()' 'use(url)' ( 'withLun' | 'withName' | 'withCaching' )* ) 'attach' )*

[anuchandy]

use(url) -> from(storageAccountName, containerName, vhdName)
define[New|Existing]DataDisk(name)
storeAt(url) -> storeAt(storageAccountName, containerName, vhdName)

[anuchandy]

Team agreed on the following:

Grammar3 ::= ( 'withNewDataDisk(size)' | 'withExistingDataDisk(account, container, vhdname)' | ( 'defineNewDataDisk(name)' 'withSize(size)' 'storeAt(account, container, vhdname)'? | 'defineExistingDataDisk(name)' 'from(account, container, vhdname)' ) ( 'withLun' | 'withCaching' )* 'attach' )*

[jianghaolu]

Shall we close this as it's merged?

[anuchandy]

yes, closing