Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getProperties call for share file download to file #4527

Closed
sima-zhu opened this issue Jul 22, 2019 · 6 comments
Closed

Remove getProperties call for share file download to file #4527

sima-zhu opened this issue Jul 22, 2019 · 6 comments
Assignees
@ibrahimrabab
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@sima-zhu
Copy link
Contributor

No description provided.

@loarabia loarabia added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Jul 26, 2019
@rickle-msft
Copy link
Contributor

Of particular note, there should not be a get properties call before downloads are made. Refer to v11 for more details.

@kurtzeborn
Copy link
Member

Removing @rickle-msft since he's headed on vacation for 3 weeks.

@alzimmermsft alzimmermsft mentioned this issue Sep 11, 2019
Closed
30 tasks
@sima-zhu
Copy link
Contributor Author

sima-zhu commented Oct 4, 2019

It is already been addressed by different PRs. Alan has another one regarding inputstream and outputstream. Will follow up on that one.

@sima-zhu sima-zhu closed this as completed Oct 4, 2019
@rickle-msft
Copy link
Contributor

rickle-msft commented Oct 4, 2019 •
edited
Loading

@sima-zhu this is not adequately addressed from what I'm seeing in master. It still makes an extra getProperties call

@rickle-msft rickle-msft reopened this Oct 4, 2019
@rickle-msft
Copy link
Contributor

We should also be sure to incorporate the data integrity fixes we added to blobs.

@rickle-msft rickle-msft changed the title Optimize the download API for file and blob Remove getProperties call for share file download to file Nov 23, 2020
@alzimmermsft alzimmermsft mentioned this issue Aug 3, 2021
Closed
@ibrahimrabab ibrahimrabab mentioned this issue Nov 23, 2022
Closed
6 tasks
@ibrahimrabab
Copy link
Contributor

Closing this issue since we are unable to extract all information for ShareFileProperties through the downloadWithResponse call (such as FileSmbProperties). Returning any null values can result in breaking behavior for the user. Closing as cannot be done.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ibrahimrabab ibrahimrabab

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove getProperties from ShareFileClient.downloadToFile() ibrahimrabab/azure-sdk-for-java
6 participants
@loarabia @rickle-msft @kurtzeborn @jaschrep-msft @sima-zhu @ibrahimrabab